fix: update data connectors migrations #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ds-443.dev.renku.ch |
Panaetius
reviewed
Oct 7, 2024
| @@ -135,6 +141,8 @@ def downgrade() -> None: | |||
| schema="storage", | |||
| ) | |||
| op.drop_table("data_connector_secrets", schema="storage") | |||
| op.drop_constraint("either_project_id_or_data_connector_id_is_set", "entity_slugs", schema="common", type_="check") | |||
| op.execute("""DELETE FROM common.entity_slugs WHERE entity_slugs.data_connector_id IS NOT NULL""") | |||
There was a problem hiding this comment.
nitpick: I don't think this needs to be triple quoted.
leafty
commented
Oct 7, 2024
components/renku_data_services/migrations/versions/3cf2adf9896b_add_data_connectors.py
Outdated
Show resolved
Hide resolved
…b_add_data_connectors.py
Panaetius
approved these changes
Oct 7, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with the migrations for data connectors:
entity_slugstable.CheckConstraintcreation together with table creation, but not new constraints on an existing table, updates to them, or removing them from a table.Manually tested:
HEADdata-servicepod and run726d5d0e1f28, that is before data connectorsNote that this series of actions would fail prior to this fix.
/deploy #notest