feat: renku-core client #1652
feat: renku-core client #1652
Conversation
…#1656) * fix: Cross-Entity Search to fetch creator name from the Persons graph * fix: Recently Viewed Entities to fetch creator name from the Persons graph * fix: Search graphs provisioning not to contain creator name * feat: TS migrations that remove Person entities from the Search graphs
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
had a problem deploying
to
renku-ci-gr-1652
GitHub Actions
Error
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
| ) | ||
| .withHeader( | ||
| "Content-Type", | ||
| containing(s"${multipart.`form-data`.mainType}/${multipart.`form-data`.subType}") |
There was a problem hiding this comment.
I think you could use Renderer.renderString(multipart.`form-data`) to render the complete mimetype string. Obviously, just a bean counting detail…
knowledge-graph/README.md
Outdated
| * any non-blank String value | ||
| * image - possible values are: | ||
| * `null` for removing the current image | ||
| * any file content |
There was a problem hiding this comment.
again embarassingly bean counting :) should we write "image file" - perhaps there are supported images and some not supported - is there also a max file size?
| url = ${?RENKU_CORE_LATEST_URL} | ||
| } | ||
|
|
||
| renku-core-service-urls = ${?RENKU_CORE_SERVICE_URLS} |
There was a problem hiding this comment.
There is no sensible default possible, right? Was just thinking how the RenkuCoreUri#ForSchema is working - i.e. which kind of value is expected - an array?
There was a problem hiding this comment.
I see your point. Unfortunately, I'm not sure if we can default to something as we expect the schema version to be encoded into the hostname. I mean, we could default to, let's say http://renku-core-v10, but in case you'd like to run it successfully, a relevant entry in the /etc/hosts would need to be added. Maybe I'll add such a default.
There was a problem hiding this comment.
Ok, I see, not easy - then it's good to leave it. So an entry in /etc/hosts is required? Or "just" a resolvable url? (from the pov of the module)
| override def tailRecM[A, B](a: A)(f: A => NestedF[Either[A, B]]): NestedF[B] = Nested { | ||
| f(a).value >>= { | ||
| case Result.Success(Right(vb)) => Result.success(vb).pure[F] | ||
| case Result.Success(Left(va)) => tailRecM(va)(f).value |
There was a problem hiding this comment.
Not sure if that is really tail recursive? Perhaps we can capture the type class for Nested and delegate to it 🤔
|
|
||
| override def tailRecM[A, B](a: A)(f: A => Result[Either[A, B]]): Result[B] = | ||
| flatMap(f(a)) { | ||
| case Left(v) => tailRecM[A, B](v)(f) |
There was a problem hiding this comment.
Same thoughts as for NestedF about tail recursiveness... I know we have similar things in the tests, but maybe on prod code we can double check here?
jachro
temporarily deployed
to
renku-ci-gr-1652
GitHub Actions
Inactive
jachro
had a problem deploying
to
renku-ci-gr-1652
GitHub Actions
Error
This PR introduces a new module containing a Renku Core client
/deploy #persist