Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slug finding in token creation flow to work when project removed #1675

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

jachro
Copy link
Contributor

@jachro jachro commented Aug 28, 2023

The Token Creation flow, in some race condition cases, was failing when finding the slug in the DB. This PR makes the process more robust by losing the assumption about the slug existence in the DB.

It also does some cleaning around the logs produced by the flow.

closes #1648

@jachro jachro requested a review from a team as a code owner August 28, 2023 14:07
Copy link
Member

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jachro jachro merged commit 435fc60 into development Aug 29, 2023
13 checks passed
@jachro jachro deleted the 1648-tr-slug-finding-issue branch August 29, 2023 12:12
@jachro jachro mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TR slug finding issue
2 participants