feat!: support for data connectors on user and group namespaces #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
ciyer/storage-to-data-connectors
branch
2 times, most recently
from
1db9034
to
e8e6097
Compare
Base automatically changed from
ciyer/storageV2-refactor
to
build/data-connectors
September 18, 2024 07:13
ciyer
changed the title
ciyer
force-pushed
the
ciyer/storage-to-data-connectors
branch
4 times, most recently
from
64d9556
to
52d9aa3
Compare
ciyer
force-pushed
the
build/data-connectors
branch
from
f48cce3
to
765e524
Compare
ciyer
force-pushed
the
ciyer/storage-to-data-connectors
branch
3 times, most recently
from
4f80050
to
da51bb4
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3315.dev.renku.ch |
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/storage-to-data-connectors
branch
from
388e991
to
d3efa1b
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
leafty
reviewed
Sep 24, 2024
There was a problem hiding this comment.
We should not inject into the projectV2 API. In fact, the PR which updates the API files does split each API cleanly so that each one is handled separately. See: #3299.
leafty
requested changes
Sep 24, 2024
client/src/features/ProjectPageV2/ProjectPageContent/DataSources/DataSourceModal.tsx
Outdated
Show resolved
Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx
Show resolved
Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorModal/DataConnectorModalBody.tsx
Show resolved
Hide resolved
client/src/features/dataConnectorsV2/components/DataConnectorModal/index.tsx
Show resolved
Hide resolved
| <section className="mt-3"> | ||
| <Row> | ||
| <Col className="order-3" xs={12} xl={8}> | ||
| <DataConnectorsBox |
There was a problem hiding this comment.
As a note, it is very difficult for users to access this page (there is no top-level navigation link for it). Which means it is very difficult to create personal data connectors if we do not have a top-level create menu.
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
leafty
reviewed
Sep 25, 2024
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
…e connection This reverts commit e876667.
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
changed the title
ciyer
changed the title
ciyer
temporarily deployed
to
renku-ci-ui-3315
GitHub Actions
Inactive
ciyer
changed the title
leafty
approved these changes
Sep 30, 2024
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
ciyer
added a commit
that referenced
this pull request
Sep 30, 2024
ciyer
added a commit
that referenced
this pull request
Oct 4, 2024
ciyer
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy renku-data-services=leafty/feat-namespaced-data-connectors-4