Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] LineItem is instantiated without a factory #416

Open
lruozzi9 opened this issue Nov 3, 2023 · 0 comments
Open

[Bug] LineItem is instantiated without a factory #416

lruozzi9 opened this issue Nov 3, 2023 · 0 comments
Labels
Bug Confirmed bugs or bugfixes.

Comments

@lruozzi9
Copy link

lruozzi9 commented Nov 3, 2023

SyliusRefundPlugin version affected: 1.4.0

Description
In

RefundPlugin/src/Converter/LineItem/OrderItemUnitLineItemsConverter.php

Line 70 in 66c42d3

return new LineItem(
the LineItem entity is created statically without a factory class

Steps to reproduce
Add an extension of the LineItem class. When you class entityManager->flush(); it will fail because it is expected to be an instance of LineItem extension.

Possible Solution
Use a factory class.
@lruozzi9 lruozzi9 added the Bug Confirmed bugs or bugfixes. label Nov 3, 2023
@NoResponseMate NoResponseMate mentioned this issue Feb 12, 2024
Merged
GSadee added a commit that referenced this issue Feb 13, 2024
@GSadee
refactor #423 Add missing factory for line items (NoResponseMate)
0054251 
This PR was merged into the 1.5 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.5
| Bug fix?        | kinda
| New feature?    | kinda
| Related tickets | related #416 


Commits
-------

69594b7 Add LineItemFactory
0942bc9 Use the new factory in line items converters
773ae98 [Maintenance] Update upgrade file
1f1a87f [Maintenance] Default null factories in line items converters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lruozzi9