Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load Doctrine event listeners #9424

Merged
merged 1 commit into from
May 24, 2018
Merged

Lazy load Doctrine event listeners #9424

merged 1 commit into from
May 24, 2018

Conversation

teohhanhui
Copy link
Contributor

Q A
Branch? 1.0
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Prevents errors during container compilation such as doctrine/DoctrineBundle#822

@pamil pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Potential Bug and removed Potential Bug Potential bugs or bugfixes, that needs to be reproduced. labels May 24, 2018
@pamil pamil self-requested a review May 24, 2018 11:33
@pamil pamil merged commit 317380d into Sylius:1.0 May 24, 2018
@pamil
Copy link
Contributor

pamil commented May 24, 2018

Thanks Teoh, I haven't even know this lazy attribute exists, it would make my life so much easier :)

@teohhanhui teohhanhui deleted the fix/lazy-doctrine-listener branch May 24, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teohhanhui @pamil