Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromaprint: Fix building on DSM7 #4551

Closed
wants to merge 1 commit into from

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Apr 13, 2021

Motivation: chromaprint fails to build on DSM7, this is an attempt to fix it. Tested over PR #4545
Linked issues:

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@th0ma7 th0ma7 requested a review from publicarray April 13, 2021 00:42
@th0ma7
Copy link
Contributor Author

th0ma7 commented Apr 13, 2021

@publicarray Applied over your PR this looks like allowing chromaprint to finally build successfully with DSM7.

@publicarray
Copy link
Member

publicarray commented Apr 13, 2021

Looks good!

$ fpcalc -version
fpcalc: Relink `/var/packages/chromaprint/target/lib/libpng16.so.16' with `/lib/libpthread.so.0' for IFUNC symbol `longjmp'
fpcalc version 1.5.0 (FFmpeg Lavc58.91.100 Lavf58.45.100 SwR3.7.100)

This relink message is odd, but it still works ok: (x64-7.0). I would be nice to have it fixed, but it's not a stopper.

$ fpcalc -plain /volume1/Media/Music/test.opus 
fpcalc: Relink `/var/packages/chromaprint/target/lib/libpng16.so.16' with `/lib/libpthread.so.0' for IFUNC symbol `longjmp'
AQADtFGqZVKUKAnC4zvuD3-OnzC[...]

I also found this in the logs. This not a bug here, it's in the genetic service scripts. (just here to remind me, @hgy59 or you, if you want to take it)

2021/04/13 08:19:46	===> Step preupgrade. USER=chromaprint GROUP= SHARE_PATH=
2021/04/13 08:19:46	/bin/cp: cannot stat '/volume1/@appstore/chromaprint/var/.': No such file or directory

@th0ma7
Copy link
Contributor Author

th0ma7 commented Apr 13, 2021

Closing, now merged part of #4545

@th0ma7 th0ma7 closed this Apr 13, 2021
@th0ma7 th0ma7 deleted the chromaprint-dsm7-fix branch April 23, 2021 14:42
@hgy59 hgy59 mentioned this pull request May 11, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants