Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add zap2epg TV grabber to tvheadend #4680

Merged
merged 11 commits into from
Jun 19, 2021
Merged

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jun 14, 2021

Motivation: TVH lacks of built-in TV grabber as the XMLTV project is pretty much all using perl with target compiled CPAN modules making cross-build not sustainable with the framework. Changes in this PR incorporate zap2epg python EPG grabber directly to TVH. This allows using built-in routine tasks from TVH without needing additional cron jobs.
Linked issues: Superseeds previous zap2it standalone package #4608 and include requests python wheels which closes #4678

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Notes

@th0ma7 th0ma7 mentioned this pull request Jun 14, 2021
3 tasks
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 15, 2021

@hgy59 I thought it was that easy of adding a WHEELS section to the spk to get the python requests library to work.

I'm still getting ModuleNotFoundError: No module named 'requests'.
Installer log file is relatively useless:

# cat tvheadend_install.log 
Tue Jun 15 16:27:47 EDT 2021
===> Step preuninst. USER=tvheadend GROUP=sc-media SHARE_PATH=
Tue Jun 15 16:27:51 EDT 2021
===> Step postuninst. USER=tvheadend GROUP=sc-media SHARE_PATH=

Advices/pointers to solve this would be much appreciated...
(now thinking, does it install python wheels only at install time or also during upgrades?)

@th0ma7 th0ma7 mentioned this pull request Jun 16, 2021
3 tasks
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update some outdated files.

spk/tvheadend/Makefile Outdated Show resolved Hide resolved
spk/tvheadend/src/service-setup.sh Outdated Show resolved Hide resolved
spk/tvheadend/src/service-setup.sh Outdated Show resolved Hide resolved
spk/tvheadend/Makefile Outdated Show resolved Hide resolved
spk/tvheadend/src/service-setup.sh Outdated Show resolved Hide resolved
spk/tvheadend/src/service-setup.sh Outdated Show resolved Hide resolved
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 17, 2021

PR pending merge of edit4ever/script.module.zap2epg#37 to confirm download URL.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 17, 2021

please update some outdated files.

Thnx for the review @hgy59, much appreciated. As mentionned some of the changes requested are already present in PR #4545.

@th0ma7 th0ma7 mentioned this pull request Jun 19, 2021
3 tasks
@th0ma7 th0ma7 merged commit 63d036d into SynoCommunity:master Jun 19, 2021
@th0ma7 th0ma7 deleted the zap2epg branch June 19, 2021 09:52
PKG_NAME = zap2epg
PKG_VERS = 3.0
PKG_EXT = tar.gz
#PKG_DIST_NAME = v$(PKG_VERS).$(PKG_EXT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover


include ../../mk/spksrc.install-resources.mk

.PHONY: zap2it_install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace zap2it by zap2epg

@hgy59
Copy link
Contributor

hgy59 commented Jun 19, 2021

sorry my latest review is too late...

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 20, 2021

sorry my latest review is too late...

@hgy59 never too late! I'll port it over to #4686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add requests to python3 package
2 participants