beets: update to 1.5.0 & Dependencies #4946

publicarray · 2021-10-31T13:37:58Z

Motivation: The package hasn't been updated in a while.
Linked issues: #4934

https://github.com/beetbox/beets/blob/master/setup.py#L87

install.txt

Test build: https://seby.io/download/synology-7.0/beets_noarch-dsm7_1.5.0-7.spk

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

publicarray · 2021-10-31T13:38:58Z

@ucki would you be willing to try the build above and test that everything is working as intended?

ymartin59 · 2021-11-01T22:05:57Z

@publicarray Does it make sense to use recent "requirement" split (from @hgy59 for home assistant) between pure-python wheels to reduce package here too?

ucki · 2021-11-02T07:25:34Z

Hi, unfortunatly I am only a "user" so I would be willing to help but I have no clue how to install the package etc ;).

publicarray · 2021-11-02T15:16:21Z

@ucki

Hi, unfortunatly I am only a "user" so I would be willing to help but I have no clue how to install the package etc ;).

You just need to use the "Manual Install" button: https://kb.synology.com/en-sg/DSM/tutorial/How_to_install_applications_with_Package_Center#x_anchor_id6

publicarray · 2021-11-02T15:18:41Z

@ymartin59 yea maybe but there is lots of movement with python at the moment. I think that can wait for another PR but I can have a quick look.

publicarray · 2021-11-03T08:52:51Z

@ymartin59 I have no idea how any of this works. How do I know if a dependency is in pure python? I thought this is a pure python package

publicarray · 2021-11-03T10:23:03Z

@th0ma7 With python 3.10 PyYAML appears to be missing (DSM7)

2021/11/03 09:17:39	Installed version: Traceback (most recent call last):
2021/11/03 09:17:39	  File "/volume1/@appstore/beets/env/bin/beet", line 5, in <module>
2021/11/03 09:17:39	    from beets.ui import main
2021/11/03 09:17:39	  File "/volume1/@appstore/beets/env/lib/python3.10/site-packages/beets/__init__.py", line 18, in <module>
2021/11/03 09:17:39	    import confuse
2021/11/03 09:17:39	  File "/volume1/@appstore/beets/env/lib/python3.10/site-packages/confuse/__init__.py", line 8, in <module>
2021/11/03 09:17:39	    from .exceptions import * # NOQA
2021/11/03 09:17:39	  File "/volume1/@appstore/beets/env/lib/python3.10/site-packages/confuse/exceptions.py", line 3, in <module>
2021/11/03 09:17:39	    import yaml
2021/11/03 09:17:39	ModuleNotFoundError: No module named 'yaml'

Other Error I see is xxxx.whl is not a supported wheel on this platform.

FYI I use the following to make is easier to read the logs:

echo '' > /var/log/packages/beets.log
Install package
cat /var/log/packages/beets.log

th0ma7 · 2021-11-03T10:23:39Z

@ymartin59 I have no idea how any of this works. How do I know if a dependency is in pure python? I thought this is a pure python package

@Safihre had provided me with an answer on this #4921 (comment)

publicarray · 2021-11-03T10:29:26Z

Thanks maybe this belongs in the wiki?

publicarray · 2021-11-03T10:32:52Z

Oh, it's in the Tips section, but it's not obvious. I'll update it a bit

Edit: done 📔 https://github.com/SynoCommunity/spksrc/wiki/Using-wheels-to-distribute-Python-packages#tips-and-tricks

th0ma7 · 2021-11-03T10:50:56Z

@publicarray that's odd... and found this in the installation log which probably explains it:

2021/11/03 06:47:51 Begin service_postinst
2021/11/03 06:47:51 /var/packages/python310/scripts/service-setup: line 21: /volume1/@appstore/python310/bin/pip: No such file or directory
2021/11/03 06:47:51 Installed version: Python 3.10.0
2021/11/03 06:47:51 Installed modules:
2021/11/03 06:47:51 /var/packages/python310/scripts/service-setup: line 27: /volume1/@appstore/python310/bin/pip: No such file or directory
2021/11/03 06:47:51 End service_postinst

But I think I have a clue why, let me dig into it part of #4951

EDIT: @publicarray in the meantime I've disabled the python310 package online to avoid issues. And anyway @hgy59 had other pending updates to do on it.

publicarray · 2021-11-03T10:57:42Z

2021/11/03 06:47:51 /var/packages/python310/scripts/service-setup: line 27: /volume1/@appstore/python310/bin/pip: No such file or directory
2021/11/03 06:47:51 End service_postinst

Hm, that's not an error I've seen. I've got a working build now. (works on my machine ™️ )
Thanks for your help 🙏

th0ma7 · 2021-11-03T11:16:35Z

Thanks for your help pray

lol... :) I may have found why: this looks like, again, related to my third attempt at bumping crossenv==1.1.4 instead of keeping the 1.0... I'll look into it later on when I find a few spare cycles.

EDIT: Actually unrelated... it more seems I was too aggressive at removing all cross/wheels...

ymartin59 · 2021-11-12T21:18:06Z

spk/beets/Makefile

 # Pure Python package, make sure ARCH is not defined
-override ARCH=
+# override ARCH=


So discard the whole block if package is no longer "non arch"

ucki · 2021-12-05T17:57:25Z

Hi folks .. sorry for not answering earlier .. wich would the correct version I sould test ? And will it kill my old beets database ?

Greetings ucki

hgy59 · 2021-12-05T18:45:55Z

Hi folks .. sorry for not answering earlier .. wich would the correct version I sould test ? And will it kill my old beets database ?

Greetings ucki

@ucki as @th0ma7 is redesigning the whole bunch of python apps you probably can test the latest builds of #4986.
You can download the artifacts of the github build action there. Unfortunately you can only download all packages together as packages.zip and this file is about 1.9GB.
You will need the python310 and the beets spk for the CPU-Arch of your Diskstation Model.

~~@th0ma7 is beets in #4986 ready for testing?~~

EDIT:
Just saw that beets didn't build in #4986, as it was still built with noarch but is now arch dependent.

th0ma7 · 2021-12-05T21:09:07Z

Indeed, it is now arch dependent (and sadly it has to).
Still, it could be tested through #4986
I'm about to merge, just confirming all is good on armv5 before doing so (just receive my two device armv5 and armv7 so I can finally test that).

th0ma7 · 2021-12-06T11:13:35Z

@publicarray and @ymartin59 while upgrading to python310 I had to update beets to version 1.5.0 as well. Also conceptually it has now to be a arch dependent package. When looking at the changes I believe "most" of it is already included in master besides refreshing your requirements. Let me know if you need assistance, cheers!

SynoCommunity#4945 (comment)

I get ModuleNotFoundError: No module named 'yaml' or ERROR: PyYAML-6.0- xxxx .whl is not a supported wheel on this platform.

th0ma7 · 2021-12-30T15:28:08Z

spk/beets/src/requirements-crossenv.txt

-#Pillow==8.2.0               ==> cross/pillow
+# Pillow==8.2.0               ==> cross/pillow


Once #5023 is merged I recommend you to use the python310 commented solution to get Pillow to be cross-compiled using pip at the version you like instead of using cross/pillow. It then requires the following in your Makefile:

# [Pillow] DEPENDS += cross/freetype cross/libjpeg cross/zlib WHEELS_BUILD_ARGS += [Pillow] WHEELS_BUILD_ARGS += build_ext WHEELS_BUILD_ARGS += --disable-platform-guessing WHEELS_BUILD_ARGS += --enable-freetype WHEELS_BUILD_ARGS += --enable-jpeg WHEELS_BUILD_ARGS += --enable-zlib

@th0ma7

to fix CVE-2021-23437 Thanks @th0ma7 SynoCommunity#4946 (review)

because these package versions have conflicting dependencies.

publicarray changed the title ~~Update beets 1.5.0~~ beets: update to 1.5.0 Oct 31, 2021

publicarray requested a review from ymartin59 November 1, 2021 11:46

publicarray force-pushed the beets-update branch from 37590f1 to 7de5ef8 Compare November 3, 2021 10:20

ymartin59 approved these changes Nov 12, 2021

View reviewed changes

publicarray force-pushed the beets-update branch from 556ac14 to 61a315b Compare December 28, 2021 01:28

publicarray added 6 commits December 28, 2021 12:36

Update beets

c6c153d

Beets: update to python 3.10

f6613a1

pin certifi

4c9c7c8

SynoCommunity#4945 (comment)

Attempt to get python 2.10 working

4cba554

I get ModuleNotFoundError: No module named 'yaml' or ERROR: PyYAML-6.0- xxxx .whl is not a supported wheel on this platform.

Fix build

f00617c

Rebase fixes

639a0c7

publicarray force-pushed the beets-update branch from 61a315b to 639a0c7 Compare December 28, 2021 01:48

publicarray changed the title ~~beets: update to 1.5.0~~ beets: update to 1.5.0 & Dependencies Dec 28, 2021

th0ma7 reviewed Dec 30, 2021

View reviewed changes

Add Pillow using SynoCommunity#5023 method and fix update cross/pillow

76f6da6

to fix CVE-2021-23437 Thanks @th0ma7 SynoCommunity#4946 (review)

publicarray added the status/ready-to-merge label Jan 2, 2022

publicarray added 2 commits January 2, 2022 22:48

fix Cannot install Click==7.0 and Click==8.0.3

b484d6e

because these package versions have conflicting dependencies.

Update beets 1.6.0

b6900ae

publicarray added status/work-in-progress status/ready-to-merge and removed status/ready-to-merge status/work-in-progress labels Jan 2, 2022

publicarray merged commit 95f8301 into SynoCommunity:master Jan 2, 2022

publicarray deleted the beets-update branch January 2, 2022 12:12

publicarray mentioned this pull request Jan 2, 2022

Beets #4934

Closed

publicarray added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/ready-to-merge labels Jan 2, 2022

th0ma7 mentioned this pull request Jan 3, 2022

META: Python 3.10 / 3.11 package status #5043

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

beets: update to 1.5.0 & Dependencies #4946

beets: update to 1.5.0 & Dependencies #4946

publicarray commented Oct 31, 2021

publicarray commented Oct 31, 2021

ymartin59 commented Nov 1, 2021

ucki commented Nov 2, 2021

publicarray commented Nov 2, 2021

publicarray commented Nov 2, 2021

publicarray commented Nov 3, 2021 •

edited

Loading

publicarray commented Nov 3, 2021

th0ma7 commented Nov 3, 2021

publicarray commented Nov 3, 2021

publicarray commented Nov 3, 2021 •

edited

Loading

th0ma7 commented Nov 3, 2021 •

edited

Loading

publicarray commented Nov 3, 2021 •

edited

Loading

th0ma7 commented Nov 3, 2021 •

edited

Loading

ymartin59 Nov 12, 2021

ucki commented Dec 5, 2021

hgy59 commented Dec 5, 2021 •

edited

Loading

th0ma7 commented Dec 5, 2021

th0ma7 commented Dec 6, 2021

th0ma7 Dec 30, 2021 •

edited

Loading

		#Pillow==8.2.0 ==> cross/pillow
		# Pillow==8.2.0 ==> cross/pillow

beets: update to 1.5.0 & Dependencies #4946

beets: update to 1.5.0 & Dependencies #4946

Conversation

publicarray commented Oct 31, 2021

Checklist

publicarray commented Oct 31, 2021

ymartin59 commented Nov 1, 2021

ucki commented Nov 2, 2021

publicarray commented Nov 2, 2021

publicarray commented Nov 2, 2021

publicarray commented Nov 3, 2021 • edited Loading

publicarray commented Nov 3, 2021

th0ma7 commented Nov 3, 2021

publicarray commented Nov 3, 2021

publicarray commented Nov 3, 2021 • edited Loading

th0ma7 commented Nov 3, 2021 • edited Loading

publicarray commented Nov 3, 2021 • edited Loading

th0ma7 commented Nov 3, 2021 • edited Loading

ymartin59 Nov 12, 2021

Choose a reason for hiding this comment

ucki commented Dec 5, 2021

hgy59 commented Dec 5, 2021 • edited Loading

th0ma7 commented Dec 5, 2021

th0ma7 commented Dec 6, 2021

th0ma7 Dec 30, 2021 • edited Loading

Choose a reason for hiding this comment

publicarray commented Nov 3, 2021 •

edited

Loading

publicarray commented Nov 3, 2021 •

edited

Loading

th0ma7 commented Nov 3, 2021 •

edited

Loading

publicarray commented Nov 3, 2021 •

edited

Loading

th0ma7 commented Nov 3, 2021 •

edited

Loading

hgy59 commented Dec 5, 2021 •

edited

Loading

th0ma7 Dec 30, 2021 •

edited

Loading