Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<attRef> needs to be handled in the transpile stage #25

Closed
martindholmes opened this issue Apr 10, 2024 · 2 comments
Closed

<attRef> needs to be handled in the transpile stage #25

martindholmes opened this issue Apr 10, 2024 · 2 comments
Assignees
@sydb @martindholmes @HelenaSabel
Labels
bug Something isn't working

Comments

@martindholmes
Copy link
Collaborator

Currently, the <attRef> element is ignored in the ATOP transpile stage, but we have concluded that it should survive to the PLODD stage, and be handled there. This enables changes to attributes in classSpecs to be handled in the derivation stage, and the <attRef> then inherits those changes at the transpile stage; this is what the current stylesheets appear to do, and seems intuitive to us.
@martindholmes martindholmes added the bug Something isn't working label Apr 10, 2024
martindholmes added a commit that referenced this issue Apr 10, 2024
@martindholmes
Tweaks and commented-out work related to issue #25.
6dba76d
martindholmes added a commit that referenced this issue May 8, 2024
@martindholmes
Preliminary implementation of issue #25 without tests as yet.
e8066bf
@martindholmes
Copy link
Collaborator Author

@HelenaSabel and I working in the branch iss-25-attRef-in-plodd have implemented attRef handling in the transpile stage, and added an instance to a test PLODD, and confirmed that the output looks right. However, we now need to add valid and invalid instances to the elements_in_classes PLODD test suite to be sure that things are working properly.

@martindholmes
Copy link
Collaborator Author

This is done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sydb sydb

@martindholmes martindholmes

@HelenaSabel HelenaSabel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sydb @martindholmes @HelenaSabel