Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying pricelist entry group to "all" does not display a change #324

Closed
Bonfire opened this issue Feb 10, 2021 · 4 comments · Fixed by #327 or #336
Closed

Modifying pricelist entry group to "all" does not display a change #324

Bonfire opened this issue Feb 10, 2021 · 4 comments · Fixed by #327 or #336
Assignees
@Bonfire
Labels
enhancement New feature or request

Comments

@Bonfire
Copy link
Member

Bonfire commented Feb 10, 2021

Describe the bug
When updating a pricelist entry's group from anything to all, the bot does not show the group being changed.

To Reproduce
Steps to reproduce the behavior:

  1. Change a pricelist entry's group to something
  2. Change the same pricelist entry's group to all
  3. Verify that while an update message was shown, the group change is not displayed

Expected behavior
The update message should have an entry for 🔰 Group: <PREVIOUS GROUP> → all like it does for 🔰 Group: all → <NEW GROUP>. This may be done on purpose, and if it is I believe that it should be modified

Screenshots and logs
image

Additional context
N/A

Version: TF2Autobot@v3.2.5
@Bonfire Bonfire added the bug Something isn't working label Feb 10, 2021
@idinium96
Copy link
Member

idinium96 commented Feb 10, 2021 •
edited
Loading

It's intended.

tf2autobot/src/classes/Commands/functions/pricelistManager.ts

Line 368 in 39cc13e

`${entry.group !== 'all' ? `\n🔰 Group: ${entry.group}` : ''}` +

tf2autobot/src/classes/Commands/functions/pricelistManager.ts

Lines 853 to 859 in 39cc13e

`${
newEntry.group !== 'all'
? `\n🔰 Group: ${
oldEntry.group !== newEntry.group ? `${oldEntry.group} → ${newEntry.group}` : newEntry.group
}`
: ''
}` +

@idinium96 idinium96 removed the bug Something isn't working label Feb 10, 2021
@Bonfire
Copy link
Member Author

Bonfire commented Feb 10, 2021

Then shall we mark this as an enhancement? I believe the change should be shown.

@idinium96
Copy link
Member

up to you. much better if you do commit and create a pull request for it 😇

@Bonfire
Copy link
Member Author

Bonfire commented Feb 10, 2021

up to you. much better if you do commit and create a pull request for it 😇

Can do 😛

@Bonfire Bonfire self-assigned this Feb 10, 2021
@Bonfire Bonfire added the enhancement New feature or request label Feb 10, 2021
Bonfire pushed a commit to Bonfire/tf2autobot that referenced this issue Feb 10, 2021
refactor: 💡 always show group on item add
4ec5be8 
This change makes it so that whenever an item is added, it will always
show which group the item is in (even if that group is all)

✅ Closes: TF2Autobot#324
Bonfire pushed a commit to Bonfire/tf2autobot that referenced this issue Feb 10, 2021
refactor: 💡 always show group on item update
172e0cf 
This change makes it so that whenever an item is updated, it will always
show which group the item is in (even if that group is all)

✅ Closes: TF2Autobot#324
@Bonfire Bonfire linked a pull request Feb 10, 2021 that will close this issue
Group "all" updates #327
Merged
@idinium96 idinium96 linked a pull request Feb 12, 2021 that will close this issue
Prepare v3.3.0 #336
Merged
@idinium96 idinium96 mentioned this issue Feb 12, 2021
Merged
idinium96 added a commit that referenced this issue Feb 14, 2021
@idinium96
🔀Merge pull request #336 from TF2Autobot/development
2d3822c 
#336 for v3.3.0

## Added
- ✨ option to filter buy order that the bot can't afford to buy. Read: #332 - @idinium96
- ✨🎨 An option to replace keys & pure metals with emoji (Discord Webhook) - @idinium96
    - added `showPureInEmoji` under `tradeSummary` option parent property.
    - this option is `false` by default. Set it to `true` (by sending `!config tradeSummary.showPureInEmoji=true` to your bot) if you want to enable this feature.
    - screenshot: 
![image](https://user-images.githubusercontent.com/47635037/107742639-6554dd00-6d4a-11eb-8a64-fa9d81b2d8cc.png)
![image](https://user-images.githubusercontent.com/47635037/107866197-0063c900-6ea9-11eb-8996-42ea98142637.png)

- ✨ add missing `isFull` attribute (for duel/noise) - @idinium96
- ✨🔨 add missing highValue meta, only define if true, and 🎨🔨 simplified - @idinium96
- ✨ add `!offerinfo` command - @idinium96

## Changed/Updated
- 💡 refactor: always show `group` on item add/update (#324) - @Bonfire
- 🔨 refactor: Commands, from functions to sub-classes - @idinium96
- 🔨 refactor: take out `meta` from `action` - @idinium96
    - 🔥 remove `notify` & `meta` from polldata on successful accepted, declined, cancelled, and invalidItems trades (reduce polldata file size)
- ⬆ increase setTimeout retry time from 3 seconds to 30 seconds - @idinium96
- ⬆ increase pollInterval from 1 second to 30 seconds (use less CPU) - @idinium96
- 🎨 bring back square bracket if `showChanges` is enabled - @idinium96
- ⭕ ignore trades from admins to count in profit (#299) - @idinium96
- 🔔 notify the owner if there's an error while trying to accept mobile confirmation (will not perform automatic retry here) - @idinium96
    - if the error is `HTTP error 502`, there is a high chance that the offer is still active, otherwise, it's most likely canceled (idk how to make it not to cancel the trade).
- 🔄 update `options` schema - @idinium96
    - get rid of `allOf` - prevent the owner from putting invalid option property.
    - **those that might already add some foreign properties (such as `enabled` for an actual `enable` key), your bot might not be able to start if you update to this version. Be sure to check your bot logs.**

## Fixed
- 🔄 update `bptf-listings-2` library
    - 🐛 fix not detect Festivized items ([`bptf-listings-2: cc136f0`](idinium96/node-bptf-listings-2@cc136f0)) - @idinium96
    - 🐛 fix and convert stock weapon defindex into upgradeable weapon defindex (`bptf-listings-2:` [`387e0a3`](idinium96/node-bptf-listings-2@387e0a3), [`b029d59`](idinium96/node-bptf-listings-2@b029d59)) - @idinium96
    - 🐛 fix defindex for Killstreak (Basic) Kit ([`bptf-listings-2: e2f0152`](idinium96/node-bptf-listings-2@e2f0152)) - @idinium96
    - 🐛 fix exclusive promo items defindex ([`bptf-listings-2: 3076fa4`](idinium96/node-bptf-listings-2@3076fa4))  - @idinium96
    - 🐛 fix wrong wear value ([`bptf-listings-2: 953f6c3`](idinium96/node-bptf-listings-2@953f6c3)) - @idinium96
- 🐛 fix `!check` command always getting error - @idinium96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonfire Bonfire

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Group "all" updates Bonfire/tf2autobot
Prepare v3.3.0 TF2Autobot/tf2autobot
2 participants
@Bonfire @idinium96