Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB as a separate database #54

Closed
abondvt89 opened this issue Mar 26, 2019 · 8 comments · Fixed by #234
Closed

Add MariaDB as a separate database #54

abondvt89 opened this issue Mar 26, 2019 · 8 comments · Fixed by #234
Labels
database Database specific enhancement New feature or request High Priority

Comments

@abondvt89
Copy link
Contributor

No description provided.

@abondvt89 abondvt89 added database Database specific High Priority enhancement New feature or request labels Mar 26, 2019
@sm-shaw
Copy link
Contributor

sm-shaw commented Jul 19, 2019

starting template now in https://github.com/sm-shaw/HammerDB/tree/54

@Jiang-Hua
Copy link
Contributor

Added MariaDB as a separate database in https://github.com/Jiang-Hua/HammerDB.git

@Jiang-Hua
Copy link
Contributor

An extension to TCL that provides access to MariaDB server.
https://github.com/Jiang-Hua/mariatcl.git

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 14, 2021

This looks great. I will review the code from the current repositories and provide any feedback. There may be some minor changes to update to features in the v4.1 release eg in the opt file there is now the option for logging the transaction counter output, however the changes needed should be minor.

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 16, 2021

I have made pull requests to both the extension and the MariaDB code itself.
Please check and verify the changes. It now looks good to create a pull request to the main TPC-Council/HammerDB project.

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 16, 2021

Testing done on GUI & CLI with TPROC-C and TPROC-H. Added additional v4.1 features already in MySQL.
For TPROC-C Use allwarehouse, time profile (v4.1) asynch scale and connect pooling have all been tested and verified to work.
Pull request Jiang-Hua#1 removed some additional indentation formatting as this had offset the scripts in the script editor and also prevented some of the dynamic insertion points working for some of the features above.
One integrated further testing is recommended however this is now fully working as an interface to MariaDB using mariatcl and the MariaDB provided library without using any mysql software.
Pull request for mariatcl interface here Jiang-Hua/mariatcl#1

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 17, 2021

Screenshot HammerDB with MariaDB
mdb

@Jiang-Hua
Copy link
Contributor

Merged the changes from Shaw and created a pull request to the main TPC-Council/HammerDB project.

@sm-shaw sm-shaw linked a pull request Apr 20, 2021 that will close this issue
abondvt89 added a commit that referenced this issue May 4, 2021
Add MariaDB as a separate database #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Database specific enhancement New feature or request High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants