Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Linux hammerdb executable work with spaces in PATH #298

Merged

Conversation

JelteF
Copy link
Contributor

@JelteF JelteF commented Dec 15, 2021

If the $PATH variable contained spaces then it would result in an error
like this:

./hammerdb: 6: export: (x86)/Microsoft: bad variable name

By double quoting the usage of the existing $PATH variable bash handles
this correctly.

If the $PATH variable contained spaces then it would result in an error
like this:

```
./hammerdb: 6: export: (x86)/Microsoft: bad variable name
```

By double quoting the usage of the existing $PATH variable bash handles
this correctly.
@sm-shaw
Copy link
Contributor

sm-shaw commented Jan 10, 2022

I have tested and confirmed that the error "bad variable name" is received if there are spaces already in the PATH environment variable, and this is resolved by double-quoting. I have also tested on Windows to verify there is no impact.
This is all fine, so recommended for acceptance by the TPC-OSS subcommittee.

@sm-shaw
Copy link
Contributor

sm-shaw commented Jan 11, 2022

Merging Pull Request as voted on by TPC-OSS subcommittee on 11th Jan 2022.

@sm-shaw sm-shaw merged commit 918223e into TPC-Council:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants