readline: only catch signals when using interact #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `./hammerdbcli auto somescript.ctl` on Linux it was impossible to stop the benchmark by using Ctrl+C. This was pretty annoying since it is the most common way to stop programs in a shell on Linux. The reason was that the readline module was explicitly ignoring SIGINT. This makes sense for interactive mode, but when using `auto` there's no reason for this. This change makes sure the signal capturing code is only executed once `TclReadLine::interactive` is called.
|
I have tested this on Linux and Windows and this is also recommended for acceptance. |
|
Merging Pull Request as voted on by TPC-OSS subcommittee on 11th Jan 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
./hammerdbcli auto somescript.ctlon Linux it wasimpossible to stop the benchmark by using Ctrl+C. This was pretty
annoying since it is the most common way to stop programs in a shell on
Linux. The reason was that the readline module was explicitly ignoring
SIGINT. This makes sense for interactive mode, but when using
autothere's no reason for this.
This change makes sure the signal capturing code is only executed once
TclReadLine::interactiveis called.