Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #388

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix typos #388

merged 1 commit into from
Jul 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2022

Build/Bawt-2.1.0/Bawt.tcl
ChangeLog
DocBook/docs.xml
agent/agent
images/icons.tcl
modules/comm-4.5.6.tm
modules/etprof-1.1.tm
modules/huddle-0.3.tm
modules/json-1.3.4.tm
modules/promise-1.1.0.tm
modules/reformat_tcl-1.0.tm
modules/rest-1.4.tm
modules/socktest-0.2.tm
modules/tablelist_tile-5.18.tm
modules/task-1.1.1.tm
modules/tkcon-2.4.tm
modules/tooltip-1.4.6.tm
modules/xtprof-1.0.tm
src/generic/gencnv.tcl
src/generic/gened.tcl
src/generic/gengen.tcl
src/generic/genhelp.tcl
src/generic/genstep.tcl
src/mariadb/mariaopt.tcl
src/mysql/mysqlopt.tcl
src/oracle/oramet.tcl
src/postgresql/pgmet.tcl
src/postgresql/pgoltp.tcl
src/trafodion/trafoltp.tcl

@ghost ghost mentioned this pull request Jul 13, 2022
Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reviewed all changes and confirm that all typos fixed are in comments or message output so fine to accept.

@ghost
Copy link
Author

ghost commented Jul 15, 2022

this is ready to merge

the docs.xml file might be revisited at some point

for example, this appears in the online rendered commit

-       generated data is delimited by a pip character ie “|” and intended NULL
+       generated data is delimited by a pip character, i.e. “|” and intended NULL

should be pipe not pip

@memmertoIBM memmertoIBM self-requested a review July 22, 2022 13:46
@memmertoIBM
Copy link
Contributor

In addition to further review on docs.xml, the changes in modules/* need to be propagated upstream at some point.

@abondvt89
Copy link
Contributor

Merging as approved by all members of the code maintenance team

@abondvt89 abondvt89 merged commit be9e508 into TPC-Council:master Jul 22, 2022
@sm-shaw sm-shaw linked an issue Aug 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typos
3 participants