Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing queries for Columnstore issue 459 #460

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fixing queries for Columnstore issue 459 #460

merged 1 commit into from
Dec 7, 2022

Conversation

mprostko
Copy link
Contributor

@mprostko mprostko commented Nov 17, 2022

This PR adds the logic into MariaDB's OLAP benchmark scripts to use different queries based on the engine used. Resolves #459

Copy link
Contributor

@memmertoIBM memmertoIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The differences in table definition boil down to two things:

  • column-store doesn't support column-level character set specification (eg, "binary")
  • column-store doesn't support creation of PK/FKs

We could use variable replacement to deal with the charset difference, but there's no easy way to deal with the PK/FK differences, so duplicating the CREATE TABLE statements is the best solution at this point.

Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested on a build of MariaDB 10.6 with th columnstore engine and the data is successfully loaded with this change. Note like all columnstores tested to date loading data through inserts is much (much!) slower than a row store and therefore bulk loading is recommended. Neverthless this change is very useful as it gives us the correct table structure to load into.

@abondvt89
Copy link
Contributor

Merging after reviews and approval of the three members of the code maintenance team.

@abondvt89 abondvt89 merged commit 0cfa712 into TPC-Council:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MariaDB TPROC-H columnstore mariaexec/db server: Too many keys specified; max 0 keys allowed
4 participants