Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query update for tpch columnstore benchmark #481

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Query update for tpch columnstore benchmark #481

merged 2 commits into from
Jan 9, 2023

Conversation

mprostko
Copy link
Contributor

@mprostko mprostko commented Dec 29, 2022

Closes #480

This PR updates the queries for MariaDB's OLAP tests and fixes three failing queries. Fixed queries were backported from here.

Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes on both mariadb columnstore and innodb storage engines and can confirm the queries run successfully on both.

In particular, retaining the original queries where we can and only changing them is closer to the original TPC-H specification that the workload is derived from. (As the specification doesn't permit rewriting)

@memmertoIBM
Copy link
Contributor

In particular, retaining the original queries where we can and only changing them is closer to the original TPC-H specification that the workload is derived from. (As the specification doesn't permit rewriting)

The addition of correlation names (AS CLAUSE) is allowed as a "minor query modification" as per TPC-H 2.2.3.3 h).

That said, since the existing query text is not ambiguous in the first place, the need for additional correlation names in the MariaDB columnstore implementation indicates a problem with the MariaDB columnstore query parser, so this latest approach is best.

@abondvt89 abondvt89 merged commit f3e28b1 into TPC-Council:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MariaDB Columnstore TPROC-H query failures
4 participants