Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Heatwave TPROC-H support #483

Merged
merged 8 commits into from
Jan 9, 2023
Merged

MySQL Heatwave TPROC-H support #483

merged 8 commits into from
Jan 9, 2023

Conversation

mprostko
Copy link
Contributor

@mprostko mprostko commented Jan 4, 2023

Closes #482

This PR adds MySQL Heatwave data generation and benchmarking support.

@mprostko mprostko requested a review from a team as a code owner January 4, 2023 13:04
@mprostko mprostko changed the title MySQL Heatwave TPROC-H query enablement MySQL Heatwave TPROC-H support Jan 4, 2023
Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs fine on a regular MySQL instance but prints an error that says the performance_schema.rpd_table_id does not exist when identifying the storage engine.
Request an update to fall back to query information_Schema.tables in case the first query fails. An example I have tested with the preferred outcome is below.

if { [ tsv::get application abort ] } { break }

catch {set engine [ join [ mysql::sel $mysql_handler "SELECT case when count(NAME) = 8 then 'Heatwave' else 'InnoDB' end as hw_loaded_all FROM performance_schema.rpd_table_id where NAME like '$db.%'" -list ] ]}
if { $mysqlstatus(code)  } {
catch {set engine [  join [ mysql::sel $mysql_handler  "select distinct(engine) from information_Schema.tables where table_schema = '$db'" -list] ]}
}
if { $mysqlstatus(code)  } {
set engine ""
}

set start [ clock seconds ]

@mprostko
Copy link
Contributor Author

mprostko commented Jan 9, 2023

@sm-shaw code updated

@sm-shaw
Copy link
Contributor

sm-shaw commented Jan 9, 2023

Have retested after changes on an innodb storage engine installation and build and test runs without warning messages

@abondvt89 abondvt89 merged commit 8552c32 into TPC-Council:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL Heatwave TPROC-H support
4 participants