Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unneeded Indices From TPROC-H MSSQL #616

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

JoshInnis
Copy link
Contributor

When Column store indices are enabled, the non unique indices on the columns are not required. Removing them will improve the load time of the TPCH load.

@JoshInnis JoshInnis requested a review from a team as a code owner October 6, 2023 23:28
When Colstore is enabled, the non unique indices on the columns are not
required. Removing them will imporve the load time of the TPCH load.
Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and build works correctly

Copy link

@jamiere-msft jamiere-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Josh earlier on this. This matches our TPC-H implementation that we give to our partners for publishing results.

@sm-shaw sm-shaw merged commit 8c9c5e6 into TPC-Council:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants