Add bcp -u option for SQL Server to trust the server certificate #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2024
jamiere-msft
approved these changes
Jan 5, 2024
abondvt89
approved these changes
Jan 9, 2024
|
Merging after reviews and approval of the three members of the code maintenance team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds -u option to bcp based builds when running on Linux with ODBC driver 18 and trust server certificate is checked to avoid
certificate verify failed:self signed certificateerror.Tests on Windows showed bcp used ODBC 17 so change has not been added to Windows but may need to be in future.
Noting that the long-term solution is to extend the ODBC interface that HammerDB uses to include bcp based commands #594 as issues such as this are a direct result of calling the external tools i.e. we have already logged in and trusted the server certificate, however using the bcp executable means we need to do this again.