39 MySQL prepared statements #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request also fixed warnings in stored procedures for date formatting using str_to_date and added return value to slev stored procedure. Added Fetch values to driver scripts to ensure consistency with other implementations. |
|
Accepting pull request as voted on February 18, 2020 in the TPC-OSS subcommittee. |
marcocitus
reviewed
Mar 30, 2020
| set Name $Parent.f1.e8a | ||
| set Prompt $Parent.f1.p8a | ||
| ttk::label $Prompt -text "PostgreSQL Tablespace :" | ||
| ttk::entry $Name -width 30 -textvariable pg_tspace |
There was a problem hiding this comment.
It seems this PR accidentally undoes the table space changes for PostgreSQL in #95.
That causes errors when trying to run TPC-C against PostgreSQL:
Error: can't read "pg_tspace": no such variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds user configurable option to use server side prepared statements in the driver script. Also adds option to connect by socket when testing on a local server.