Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(react-query): correct links in the prefetching.md file #7671

Merged
merged 2 commits into from
Jul 8, 2024
Merged

docs(react-query): correct links in the prefetching.md file #7671

merged 2 commits into from
Jul 8, 2024

Conversation

87xie
Copy link
Contributor

@87xie 87xie commented Jul 4, 2024

Similar to #7211 and #7658, use path-based navigation.

Additionally, the [a full React Query example](https://tanstack.com/router/v1/docs/examples/react/with-react-query?file=src%2Fmain.tsx) is also an invalid link. I am not sure which example is currently recommended, I think Basic React Query File Based looks good to me. If there's a better option, please let me know.

After

after.mov

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 4, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c12c367. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TanStack TanStack deleted a comment from vercel bot Jul 8, 2024
@TanStack TanStack deleted a comment from codesandbox-ci bot Jul 8, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: c12c367

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7671

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7671

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7671

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7671

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7671

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7671

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7671

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7671

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7671

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7671

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7671

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7671

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7671

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7671

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7671

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7671

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7671

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7671

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7671

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7671

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7671

templates

@lachlancollins lachlancollins merged commit c107fc5 into TanStack:main Jul 8, 2024
5 checks passed
@87xie 87xie deleted the correct-links-in-react-query-prefetching-doc branch July 8, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlancollins lachlancollins lachlancollins approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@87xie @lachlancollins