Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): Modernise React examples #7704

Merged
merged 13 commits into from
Jul 10, 2024
Merged

docs(examples): Modernise React examples #7704

merged 13 commits into from
Jul 10, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jul 10, 2024 •
edited
Loading

  • Replaced react/basic with react/basic-typescript
  • Added typescript to react/basic-graphql-request, react/default-query-function, react/offline, react/suspense, react/simple
  • Removed "browserslist" config as Vite does not use this anymore
  • Replaced simple axios and ky functions with fetch
  • Tweaked solid/basic and solid/basic-graphql-request to match react examples

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96a640f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 10, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 96a640f

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7704

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7704

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7704

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7704

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7704

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7704

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7704

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7704

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7704

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7704

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7704

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7704

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7704

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7704

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7704

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7704

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7704

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7704

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7704

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7704

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7704

templates

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.56%. Comparing base (362f8e6) to head (96a640f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7704   +/-   ##
=======================================
  Coverage   44.56%   44.56%           
=======================================
  Files         185      185           
  Lines        7062     7062           
  Branches     1554     1555    +1     
=======================================
  Hits         3147     3147           
  Misses       3552     3552           
  Partials      363      363
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query 84.36% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 92.86% <ø> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.98% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 90.00% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.42% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins marked this pull request as ready for review July 10, 2024 01:51
@lachlancollins lachlancollins changed the title docs(examples): Update React examples docs(examples): Modernise React examples Jul 10, 2024
@lachlancollins lachlancollins merged commit 7fc9472 into main Jul 10, 2024
7 checks passed
@lachlancollins lachlancollins deleted the update-examples branch July 10, 2024 01:52
@lachlancollins lachlancollins mentioned this pull request Jul 17, 2024
Closed
@Sourav-Goyal19 Sourav-Goyal19 mentioned this pull request Aug 1, 2024
Merged
@dn54321 dn54321 mentioned this pull request Aug 1, 2024
Open
This was referenced Aug 2, 2024
Open
Open
Open
This was referenced Aug 2, 2024
Closed
Merged
Merged
Closed
This was referenced Aug 2, 2024
Closed
Merged
Merged
This was referenced Aug 4, 2024
Open
Open
Open
This was referenced Aug 7, 2024
Merged
Closed
Closed
@mostafatamer11 mostafatamer11 mentioned this pull request Aug 7, 2024
Open
@dn54321 dn54321 mentioned this pull request Aug 7, 2024
Open
@mostafatamer11 mostafatamer11 mentioned this pull request Aug 8, 2024
Open
@dn54321 dn54321 mentioned this pull request Aug 8, 2024
Open
@zntb zntb mentioned this pull request Aug 9, 2024
Merged
@mostafatamer11 mostafatamer11 mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lachlancollins