[fix] 토큰 재발급 이슈 해결 #247
Merged
[fix] 토큰 재발급 이슈 해결 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
approved these changes
Mar 10, 2024
| @@ -134,6 +136,20 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home | |||
| } | |||
|
|
|||
| private fun collectData() { | |||
| combine( | |||
There was a problem hiding this comment.
아하 지도뷰 / 리스트뷰 동시에 서버통신 보내지면서 이슈가 생긴 거였나보네요
서버통신을 2개 같이 보내면 이런 문제가 생긴다는 사실을 첨 알았서여
HAJIEUN02
reviewed
Mar 10, 2024
| homeViewModel.category.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.searchWord.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.mainListOrderType.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.homeViewType.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged() |
There was a problem hiding this comment.
근데 아무리 생각해도 여기 왜 distinctUntilChanged가 있어야 작동이 제대로 되는 건지 모르겠네핑,,,,
repeatOnLifecycle을 사용해보면 어떨까요?? 저도 잘 모르는 부분이긴 한데 찾아보니까 여러 flow에서 수집해야 하는 경우 사용하는 거라는데..
There was a problem hiding this comment.
이번 스프린트 끝나고 리팩할 때 시도해봐야겠서요,,, 함냐 ㅜ 생명주기 관련 문제인 것 같긴 한데핑,,,
DoReMinWoo
reviewed
Mar 10, 2024
Comment on lines
+139
to
+146
| combine( | ||
| homeViewModel.category.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.searchWord.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.mainListOrderType.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged(), | ||
| homeViewModel.homeViewType.flowWithLifecycle(viewLifecycleOwner.lifecycle).distinctUntilChanged() | ||
| ) { _, _, _, homeViewType -> | ||
| homeViewType | ||
| }.onEach { homeViewType -> |
There was a problem hiding this comment.
combine 공부좀 해야겠네요 ㅠㅠ 봐도 모르겠심
DoReMinWoo
approved these changes
Mar 10, 2024
이거는 재발급 로직을 바꿔야 함요 ㅜ 건빵은 동기적으로 만들었다는데 그렇게 해야할 듯,, 아직은 2개 보내는 경우가 없으니까,, 일단 이대로 가고,, 그런 경우가 생기면 수정합시둥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
base url 나오면 안 될 것 같아서 일부만 캡쳐 ㅋㅋ
Uncompleted Tasks 😅
To Reviewers 📢