-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] 3차 스프린트 QA 수정사항 반영 #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실기기 확인했는데 안짤리고 잘 나오네요!
private fun initLayout() { | ||
when (intent.getStringExtra(FROM_ACTIVITY)) { | ||
MY_GROUP_ACTIVITY -> Unit | ||
else -> setDoubleBackPressToExit(binding.root) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오홍 코드 깔끔하네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
증말용? ㅎ.ㅎ 이걸 initLayout 함수 내에 넣는게 맞나 살짝 고민됐는데 어케 생각하세염 ㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿뜨
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
app:layout_constraintTop_toBottomOf="@id/tv_onboarding_explanation_skip" | ||
app:layout_constraintBottom_toTopOf="@id/tl_onboarding_indicator" /> | ||
android:layout_height="wrap_content" | ||
app:layout_constraintTop_toBottomOf="@id/tv_onboarding_explanation_skip" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width는 matchparent보다 0dp를 사용하는 게 좋아보이네요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넹 일어나자마자 수정할게여!
app:layout_constraintTop_toBottomOf="@id/vp_onboarding_explanation" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintBottom_toTopOf="@id/btn_onboarding_explanation_next" | ||
android:layout_marginBottom="58dp" | ||
android:layout_marginBottom="18dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 탭 레이아웃 정렬과 관련해서 디자인 측이랑 대화를 한 번 해보시는 게 좋을 것 같아요.
지금 이 제약이라면 뷰페이저와 버튼 사이 공간에 탭 레이아웃이 가운데 정렬되게 되는데요.
디자인 측에서 원하는 디자인이 그게 맞는지,, 확인이 필요할 것 같아용 ~
이거 그리고 왜 18로 수정되는지 설명 부탁ㅇㅣ요 ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 위 텍스트랑은 40dp 차이가 나고 아래 버튼이랑은 58dp 차이가 나는데요.. 위 아래 제약을 다 걸어서 중앙정렬이 된 상태에서 아래에 마진 18dp 추가하는 느낌으로 구현햇숨다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아 이거 아래 마진 18 두고 중앙 정렬인지,, 아니면 그냥 버튼 위로 58만큼 떨어지게를 원하는 건지,, 아니면 뷰페이저 아래로 40을 원하는 건지 한 번 체크해줘요 ~~
when (intent.getStringExtra(FROM_ACTIVITY)) { | ||
MY_GROUP_ACTIVITY -> Unit | ||
else -> setDoubleBackPressToExit(binding.root) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지렸핑 ㄷ.ㄷ when문 사용하신 건 추후 확장성을 고려한 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 확장성 고려라기보다는 if else문보다 훨씬 보기 깔끔하다고 느껴져서 이렇게 했는데 나중에 뷰가 추가된다거나 플로우가 좀더 정리되면 수정하기 편하겠군요
그러나!!!! const val은 확장성 고려해서 여러번 선언 안하구 두 뷰에서 import해서 활용했삼요 ㅎ.ㅎ 칭찬받고싶다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
역시 잘한다 하지은 ㅠㅠ 진짜 짱 많이 늘었서 ㅜ 내가 다 뿌듯함
@@ -28,6 +30,7 @@ class MyGroupActivity : BindingActivity<ActivityMyGroupBinding>(R.layout.activit | |||
|
|||
private val viewModel by viewModels<MyGroupViewModel>() | |||
private lateinit var adapter: MyGroupAdapter | |||
private lateinit var resultLauncher: ActivityResultLauncher<Intent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얜 없어도 될 것 같은ㄷㅔ요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉스 원래 이 방법을 쓰려다가 putExtra로 바꿔서 ,, ㅎ 역시 꼼꼼하다 지울게여ㅜ
디잔핑이 새 에셋 만들어주면 그것만 반영하고 머지하면 될 것 같네용 ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생핑
Related issue 🛠
Work Description ✏️
Screenshot 📸
adf6bca9-bdf4-4488-9d72-cf0eefa6ea44.mp4
Uncompleted Tasks 😅
N/A
To Reviewers 📢
하나는 실수로 지현언니 브랜치에 해서 PR 링크 연결해두었습니다..ㅜ
죄송핑
-> 확장함수로 바꿔서 이제 여기서도 확인할 수 있음둥
영상은 처음 가입하고 [입장 방식 선택 뷰]에 접근했을 때 이전 버튼을 누르면 앱이 종료되고, 가입 이후 [나의 단체 뷰]를 통해 접근했을 때에는 이전 버튼을 누르면 나의 단체 뷰로 다시 돌아가는 플로우를 찍어서 좀 길어요ㅜ