Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Snackbar로 인한 앱 터지는 현상 #254

Merged
merged 1 commit into from
Mar 17, 2024
Merged

[hotfix] Snackbar로 인한 앱 터지는 현상 #254

merged 1 commit into from
Mar 17, 2024

Conversation

DoReMinWoo
Copy link
Member

Related issue 🛠

Work Description ✏️

  • Fragment에서 Snackbar 호출 시 View 매개변수에 binding.root -> requireView 로 변경

Screenshot 📸

N/A

Uncompleted Tasks 😅

N/A

To Reviewers 📢

죄송합니두..

@DoReMinWoo DoReMinWoo self-assigned this Mar 16, 2024
@DoReMinWoo DoReMinWoo requested a review from a team as a code owner March 16, 2024 10:39
@DoReMinWoo DoReMinWoo linked an issue Mar 16, 2024 that may be closed by this pull request
[hotfix] Snackbar로 인한 앱 터지는 현상 #253
Closed
3 tasks
jihyunniiii
jihyunniiii reviewed Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 수정 감사합니다 오류 원인 분석이 조금 더 필요할 것 같아서 일단 잠시만 머지 보류요 ~

jihyunniiii
jihyunniiii approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크크,, 이 문제 맞는 것 같아욤,, 머지 해주시면 업뎃 다시 올릴게요 ~ 수고하셨습니당

@DoReMinWoo DoReMinWoo merged commit b55ee7a into develop Mar 17, 2024
1 check passed
@DoReMinWoo DoReMinWoo deleted the hotfix-snackbar-view branch March 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihyunniiii jihyunniiii jihyunniiii approved these changes

Assignees

@DoReMinWoo DoReMinWoo

Labels
🎅 민우 🎅 🛠️ fix 🛠️
Projects
PINGLE-ANDROID
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotfix] Snackbar로 인한 앱 터지는 현상
2 participants
@DoReMinWoo @jihyunniiii