-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 핑글 개최 프로세스 - 내용요약/확인 뷰 구현 #65
Changes from 1 commit
0e4f8d0
7bdcadd
9f44ed5
b636da2
9cc5d0e
664d517
5c6af6c
9b1a288
de8f744
ded080d
bfb3843
0f2d198
0f4b962
40737a4
7c99cab
b6205e9
17a8d76
884dc9c
7d06e51
9b877f5
0bf7f3e
88597a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -27,12 +27,29 @@ class PlanSummaryConfirmationFragment : | |||||
tvPlanSummaryConfirmationName.text = viewModel.planTitle.value | ||||||
tvPlanSummaryConfirmationOwnerName.text = "개최자" | ||||||
tvPlanSummaryConfirmationCalenderDetail.text = | ||||||
viewModel.planDate.value + "\n" + makeTimeClean(viewModel.startTime.value) + " ~ " + makeTimeClean(viewModel.endTime.value) | ||||||
makeDateClean(viewModel.planDate.value) + "\n" + makeTimeClean(viewModel.startTime.value) + " ~ " + makeTimeClean( | ||||||
viewModel.endTime.value | ||||||
) | ||||||
tvPlanSummaryConfirmationMapDetail.text = viewModel.selectedLocation.value?.location | ||||||
tvPlanSummaryConfirmationRecruitmentDetail.text = getString(R.string.plan_summary_confirmation_recruitment_number, viewModel.selectedRecruitment.value) | ||||||
tvPlanSummaryConfirmationRecruitmentDetail.text = getString( | ||||||
R.string.plan_summary_confirmation_recruitment_number, | ||||||
viewModel.selectedRecruitment.value | ||||||
) | ||||||
} | ||||||
} | ||||||
} | ||||||
|
||||||
private fun makeTimeClean(time: String): String = time.substring(0, 5) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
이런 식으로 네이밍하는 게 좋을 것 같고 0이랑 5는 상수화 해주세요 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 뭔가 직관적이지 않은 것 같아서 convertDateFormat, convertTimeFormat으로 수정했슴둥 |
||||||
private fun makeDateClean(date: String): String { | ||||||
val year = date.substring(0, 4) | ||||||
val month = date.substring(5, 7) | ||||||
val day = date.substring(8, 10) | ||||||
return year + YEAR + month + MONTH + day + DAY | ||||||
} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 위랑 비슷하게 네이밍 해주시고 상수화 진행해주세요 |
||||||
|
||||||
companion object { | ||||||
const val YEAR = "년 " | ||||||
const val MONTH = "월 " | ||||||
const val DAY = "일" | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 나중에 서버통신으로 사용자 정보 받아와서 개최자 닉네임 넣어주는 로직으로 수정해주는 거 맞죠?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 API명세서에 있는 거 씁니둥,,