Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 더보기 뷰 구현 #76

Merged
merged 10 commits into from
Jan 9, 2024
Merged

[feat] 더보기 뷰 구현 #76

merged 10 commits into from
Jan 9, 2024

Conversation

Dan2dani
Copy link
Collaborator

@Dan2dani Dan2dani commented Jan 9, 2024

Related issue 🛠

Work Description ✏️

  • 더보기 뷰 구현

Screenshot 📸

# Conflicts:
#	app/src/main/res/values/strings.xml
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘만 수정하고 머지하세요

android:id="@+id/tv_setting_nickName"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/spacing18"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
android:layout_marginTop="@dimen/spacing18"
android:layout_marginTop="32dp"

@Dan2dani Dan2dani merged commit 7e295ad into develop Jan 9, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the feat-setting-view branch January 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 설정뷰 구현
2 participants