added card confirm state #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for momentum-mentors ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzeager
requested changes
Jul 18, 2023
There was a problem hiding this comment.
These changes look great! A couple fixes before we merge it:
- Can we add some padding below the time block so if you scroll down there’s a little space below the final time?
- The props passed into MentorCard (SessionSignup.js lines 343-347) don’t match with what we expect it to receive (MentorCard.js lines 28-33). Similarly for Preview we pass along onSlotSelect, but don’t set up Preview to receive it. Can these be updated for consistency?
GitLukeW
pushed a commit
that referenced
this pull request
Sep 9, 2023
…-Redesign added card confirm state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
1. Targeted Issue
Ticket # 88
2. Overview of Solution
Redesigned the Mentor card per the figma. Started by creating the Preview.jsx component to be the preview the user sees prior to submitting the session request. Had to pass the submit throw the two other components to get the prop to preview.jsx.
Formatted the times to take out the trailing two zeros (Good call @nzeager )
Styled the three components to match the figma.
3. Tools Used
Figma, MUI, CSS
4. Testing Strategy
Tested the app by added, signing up for sessions, canceling sessions, and trying across all current mentor availabilities to ensure normal app functionality
5. Future Implications
Currently on mobile the Mentor Cards are staying to the left and leaving a large gap to the right side of the screen. Will work on that when we look at the skills icon.
6. Screenshots
Before:
After:
7. Code Reviewers
@nzeager
Before you go...
Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!