added conditional on sessions signup page so if no mentors are availa… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble at a selected time then a message displays telling the user
✅ Deploy Preview for momentum-mentors ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzeager
requested changes
Sep 1, 2023
There was a problem hiding this comment.
This is a great update! Even though this ended up being something different than the origin ticket, I think it will help a lot. And thanks for cleaning up the code some while you were at it. A few changes before I approve:
- Update the ticket number in the PR description from 60 to 114, to match the new trello ticket I created.
- Can you update the displayed message to say “No mentors are available for on this day.”? I want it to convey that there may be mentors available for that skill on other days, or mentors helping with other skills on the selected day. Feel free to suggest other ideas.
- The message currently displays when they haven’t selected a topic or day. Can we hide it in that case?
- Indent the message further in than the text “Select a mentor for:”.
I've added a screenshot for reference of fixes 2-4.
|
|
nzeager
requested changes
Sep 6, 2023
GitLukeW
pushed a commit
that referenced
this pull request
Sep 9, 2023
added conditional on sessions signup page so if no mentors are availa…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble at a selected time then a message displays telling the user
Pull Request Template
1. Targeted Issue
Render a message to show that the skills/time frame selected does not have any mentors available
Ticket #114
2. Overview of Solution
Put a conditional (filteredMentors.length === 0 ?) that would display "No Mentors are available at this time." when array length was zero.
3. Tools Used
React and MUI
4. Testing Strategy
Usage
5. Future Implications
Users will immediately know that their search parameters do not yield a search result instead of a malfunction occurring in the app.
6. Screenshots
7. Code Reviewers
Luke or Nathan will do the PR?
Before you go...
Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!