Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fork #1

Merged
merged 2 commits into from
Sep 1, 2019
Merged

Update fork #1

merged 2 commits into from
Sep 1, 2019

Conversation

Tejas2805
Copy link
Owner

No description provided.

jamessspanggg and others added 2 commits September 1, 2019 21:12
@jamessspanggg @eugenepeh
ChartView: modify the sorting of the authors to use display names (#880)
8e0a89e 
The sorting of the author by title is according to the authors' 
GitHub usernames.

Github usernames are strings that users have no control over, 
an unconfigurable field. Therefore, sorting according to it does not
have much value to the user, should she chose to configure the display
names.

Let's modify the sorting of author names to be according to the
authors' display names.
@Tejas2805 @eugenepeh
[#185] Config, Test: use realistic display names (#875)
43dadf1 
The display name of the authors' used for the demo and tests are plain.

They do not cover all the possible allowable use cases provided to
the users. This can cause bugs to go unnoticed in the test environment,
and the actual UI may deviates from our expectation.

Let's rename them to cover more actual scenarios. This includes long
names, names with special characters and numbers, and whitespace.
@Tejas2805 Tejas2805 merged commit 35ebfa7 into Tejas2805:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tejas2805 @jamessspanggg