Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update color, hover styles and remove active styles on radio btn according to VOCA #1340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannaharnett
Copy link
Contributor

  • Changed color from core-purple to black-purple
  • Changed hover styles to only show thicker border (no shadows) and only apply to enabled radio btn
  • Removed active effects

@@ -35,12 +35,12 @@
/* If the input is checked, display the inner circle with purple color */
& > input:checked ~ .radiobutton__svg-container .radiobutton__circle {
display: block;
fill: var(--core-purple);
fill: var(--black-purple);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the correct purple is the black-purple 🤔 For the button we've used this --core-purple-850. I see that they now call that color "deep purple" (like we do in oneportal), or purple 900. So not sure if we should add a color called deep purple? or if we should add the new "purple" colors. Seems like they've changed the purple scale a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants