Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): rm left align for input-nubmer when use column theme #481

Merged
merged 1 commit into from
May 29, 2022

Conversation

jchalex
Copy link
Contributor

@jchalex jchalex commented May 29, 2022

🤔 这个 PR 的性质是?

  • [✅] 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign-vue#913

💡 需求背景和解决方案

  1. 根本问题:.t-input-number.t-is-controls-right .t-input__inner 写死了 text-align: left,并且该 class 的优先级比 .t-align-center > .t-input__inner 的选择器的优先级高

image

  1. 去掉 .t-input-number.t-is-controls-right .t-input__inner 的固定左侧对齐,让 theme 样式生效

📝 更新日志

  • fix(input-number): theme 为 column 时设置 align 失效的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [✅] 文档已补充或无须补充
  • [✅] 代码演示已提供或无须提供
  • [✅] TypeScript 定义已补充或无须补充
  • [✅] Changelog 已提供或无须提供

@github-actions
Copy link

style/web/components

完成

@jchalex jchalex changed the title fix: rm left align for input-nubmer when use column theme fix(input-number): rm left align for input-nubmer when use column theme May 29, 2022
@chaishi chaishi merged commit 896b389 into Tencent:develop May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants