Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cascader-panel #1045

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Conversation

PengYYYYY
Copy link
Contributor

@PengYYYYY PengYYYYY commented Jul 5, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(CascaderPanel): 增加 cascader-panel 组件
  • feat(Cascader): 增加 inputProps, tagInputProps, tagProps 属性
  • feat(Dialog): 修复打开对话框,出现滚动条(#1163)
  • chore: 优化 demo 属性展示

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #1045 (3f2a88e) into develop (7b04365) will increase coverage by 0.29%.
The diff coverage is 59.44%.

@@             Coverage Diff             @@
##           develop    #1045      +/-   ##
===========================================
+ Coverage    60.40%   60.69%   +0.29%     
===========================================
  Files          937      953      +16     
  Lines        16498    16709     +211     
  Branches      3743     3816      +73     
===========================================
+ Hits          9966    10142     +176     
- Misses        6532     6567      +35     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8cc399...3f2a88e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

完成

@chaishi
Copy link
Collaborator

chaishi commented Jul 6, 2022

image

@chaishi
Copy link
Collaborator

chaishi commented Jul 6, 2022

有一点 PR 里面不方便看,需自测看一下:是否 Cascader 和 CascaderPanel 都支持了 className 和 style

@uyarn uyarn merged commit 2ca701a into Tencent:develop Jul 7, 2022
@github-actions github-actions bot mentioned this pull request Jul 11, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants