Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select multiple mode #1091

Merged
merged 2 commits into from
Jun 29, 2022
Merged

fix select multiple mode #1091

merged 2 commits into from
Jun 29, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jun 29, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Select): 修复多选模式下展示placeholder的异常

  • fix(Select): 修复可筛选换行高度异常的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn changed the title Fix/select multiple fix select multiple mode Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1091 (42dad8f) into develop (a0db0df) will increase coverage by 1.90%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
+ Coverage    57.56%   59.46%   +1.90%     
===========================================
  Files          346      406      +60     
  Lines        12828    15053    +2225     
  Branches      2405     2819     +414     
===========================================
+ Hits          7384     8951    +1567     
- Misses        5200     5831     +631     
- Partials       244      271      +27     
Impacted Files Coverage Δ
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/date-picker/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/drawer/props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/pagination/props.ts 72.72% <0.00%> (-27.28%) ⬇️
src/affix/affix.tsx 39.06% <0.00%> (-27.01%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc913a8...42dad8f. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@honkinglin honkinglin merged commit aa35255 into develop Jun 29, 2022
@honkinglin honkinglin deleted the fix/select-multiple branch June 29, 2022 11:40
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants