fix(textarea): 公共组件当初始处于隐藏状态再次可视后未做高度再计算的问题 #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修复用户反馈issue"[Textarea] textarea在折叠面板内时，高度计算不正确，会出现滚动条",issue详情见:Tencent#2809
t-textarea在部分场景比如t-collapse-panel中使用时,初始化加载时该组件没有高度,但是当再次可视时因为没有再次做高度的计算导致没有获得响应式高度因此出现这个问题.
|
|
uyarn
changed the title
uyarn
approved these changes
Dec 27, 2023
16 tasks
Merged
16 tasks
uyarn
pushed a commit
that referenced
this pull request
Jan 2, 2024
* fix(textarea.tsx): 修复textarea在折叠面板内时，高度计算不正确，会出现滚动条的问题 修复用户反馈issue"[Textarea] textarea在折叠面板内时，高度计算不正确，会出现滚动条",issue详情见:#2809 * fix(textarea.tsx): 修复t-textarea公共组件在初始被隐藏时没有做高度计算的问题 t-textarea在部分场景比如t-collapse-panel中使用时,初始化加载时该组件没有高度,但是当再次可视时因为没有再次做高度的计算导致没有获得响应式高度因此出现这个问题.
uyarn
added a commit
that referenced
this pull request
Jan 2, 2024
* fix(table): uploadFilePercent does not work with autoUpload=false (#2991) * fix(table): uploadFilePercent * fix: lint eorr * fix(upload): image preview * feat(card): card组件支持传入loadingProps参数 (#2959) * feat(card): card组件支持传入loadingProps参数 card组件支持传入loadingProps参数 fix #423 * chore: merge develop * feat(card): card组件支持传入loadingProps参数 card组件支持传入loadingProps参数 fix #423 * refactor(card): props属性用法优化 * chore: update snapshot * chore: update snapshot --------- Co-authored-by: Uyarn <uyarnchen@gmail.com> * fix(table): affixed bugs, filter icon highlight bug (#2990) * fix(table): affixed bugs * fix(table): fix filter can not highlight with number 0 * chore: fix pagination text (#2996) * fix(radio): the checked state also triggers the change event (#3000) * fix(radio): the checked state also triggers the change event * test(radio): the checked state also triggers the change event * docs: update FAQ (#3002) * docs: update FAQ * chore: update docs * fix(textarea): 公共组件当初始处于隐藏状态再次可视后未做高度再计算的问题 (#3003) * fix(textarea.tsx): 修复textarea在折叠面板内时，高度计算不正确，会出现滚动条的问题 修复用户反馈issue"[Textarea] textarea在折叠面板内时，高度计算不正确，会出现滚动条",issue详情见:#2809 * fix(textarea.tsx): 修复t-textarea公共组件在初始被隐藏时没有做高度计算的问题 t-textarea在部分场景比如t-collapse-panel中使用时,初始化加载时该组件没有高度,但是当再次可视时因为没有再次做高度的计算导致没有获得响应式高度因此出现这个问题. * feat: provide a method to calculate the height of textArea component after DOM mounted (#3006) * fix(textarea.tsx): 修复textarea在折叠面板内时，高度计算不正确，会出现滚动条的问题 修复用户反馈issue"[Textarea] textarea在折叠面板内时，高度计算不正确，会出现滚动条",issue详情见:#2809 * fix(textarea.tsx): 修复t-textarea公共组件在初始被隐藏时没有做高度计算的问题 t-textarea在部分场景比如t-collapse-panel中使用时,初始化加载时该组件没有高度,但是当再次可视时因为没有再次做高度的计算导致没有获得响应式高度因此出现这个问题. * fix(textarea.tsx): provide a method to calculate the height of textArea component after DOM mounted Provide a method to calculate the height of textArea component after DOM mounted * chore(deps-dev): bump @typescript-eslint/typescript-estree (#3009) --- updated-dependencies: - dependency-name: "@typescript-eslint/typescript-estree" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(imageviewer): 添加defaultScale (#3013) 添加defaultScale * docs: update popup plugin demo (#3014) * fix(upload): form disabled should effect upload trigger button (#3012) * fix(upload): form disabled should effect upload trigger button * chore: update snapshot * chore: release 1.8.4 (#3015) * chore: release 1.8.4 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: update snapshot --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sheepluo <yaoyanhuoyi@qq.com> Co-authored-by: iiimix <690360602@qq.com> Co-authored-by: betavs <34408516+betavs@users.noreply.github.com> Co-authored-by: 梓晨 <2777689609@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sinbadmaster <40019023+sinbadmaster@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
需求背景：
使用者提出issue，反馈t-textarea公共组件存在高度计算问题，经定位，该组件已知存在两个问题
解决方案：
针对问题1：需要确保高度的计算是在DOM挂载完成后进行
针对问题2：仅通过在mounted中和监听value值的变动时做高度响应式计算是不够的，还需要考虑这种初始时该组件处于“隐藏”再次可视的情况。
📝 更新日志
fix(Textarea): 修复组件初始处于隐藏状态，可视后未做高度再计算的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单