Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table DragSort Column 列拖拽排序 #755

Merged
merged 44 commits into from
Apr 19, 2022

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Apr 18, 2022

关联子仓库:Tencent/tdesign-common#405

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

Breaking Change

  • 拖拽排序,drag=sort 表示列拖拽排序,drag=row 表示行拖拽排序,drag=row-handler 表示行手柄列拖拽排序。
    如果您使用了 drag="col" 来实现行拖拽排序,请更为使用 drag="row-handler"

Bug Fix

  • fix(Table): 表头吸顶,不对齐问题
  • fix(Table): 列配置功能,按需引入 Button 组件。避免业务按需引入 Table 组件时,出现组件不存在错误
  • fix(Table): 无法使用插槽自定义过滤图标
  • fix(Table): 修复 TdBaseTableProps TdPrimaryTableProps 关于 onCellClick 的 TS 类型冲突

Table Feature

  • feat(Table): 支持简易列拖拽排序。设置 dragSort="col" 即可
  • feat(Table): 树形结构,行展开或收起时,触发事件 onTreeExpandChange

Table Refactor(无需计入 ChangeLog)

  • fix some typo error

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

sheepluo and others added 30 commits February 11, 2022 20:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #755 (4708c40) into develop (a0db0df) will increase coverage by 4.07%.
The diff coverage is 68.63%.

❗ Current head 4708c40 differs from pull request most recent head 5d571dd. Consider uploading reports for the commit 5d571dd to get more accurate results

@@             Coverage Diff             @@
##           develop     #755      +/-   ##
===========================================
+ Coverage    57.56%   61.63%   +4.07%     
===========================================
  Files          346      348       +2     
  Lines        12828    13055     +227     
  Branches      2405     2478      +73     
===========================================
+ Hits          7384     8047     +663     
+ Misses        5200     4758     -442     
- Partials       244      250       +6     
Impacted Files Coverage Δ
src/cascader/components/InputContent.tsx 65.62% <0.00%> (+5.20%) ⬆️
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/form/const.ts 100.00% <ø> (ø)
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/table/base-table-props.ts 61.53% <ø> (ø)
src/table/enhanced-table-props.ts 100.00% <ø> (ø)
src/table/hooks/useClassName.ts 100.00% <ø> (ø)
src/table/hooks/useFilter.tsx 37.66% <ø> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bfb39...5d571dd. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2022

完成

@uyarn uyarn merged commit 7053860 into Tencent:develop Apr 19, 2022
@github-actions github-actions bot mentioned this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants