Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): 去掉select选中和下拉项中的title属性 #777

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

LoopZhou
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Fixes #769

💡 需求背景和解决方案

目前select选中项和select的下拉项中均有title属性, 并且没有提供相应控制。
由于业务上需要自定义提示信息样式,经讨论去掉select选中和下拉项中的title属性

📝 更新日志

  • fix(select): 去掉select选中和下拉项中的title属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #777 (c1bda2d) into develop (a0db0df) will increase coverage by 4.22%.
The diff coverage is 69.04%.

@@             Coverage Diff             @@
##           develop     #777      +/-   ##
===========================================
+ Coverage    57.56%   61.78%   +4.22%     
===========================================
  Files          346      354       +8     
  Lines        12828    13190     +362     
  Branches      2405     2492      +87     
===========================================
+ Hits          7384     8150     +766     
+ Misses        5200     4787     -413     
- Partials       244      253       +9     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
src/menu/menu.tsx 61.90% <ø> (ø)
src/select/option.tsx 16.66% <ø> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1516dd0...c1bda2d. Read the comment docs.

@xiaosansiji xiaosansiji merged commit 572d8e7 into Tencent:develop Apr 22, 2022
@github-actions github-actions bot mentioned this pull request Apr 24, 2022
@LoopZhou LoopZhou deleted the fix/zmy-select-title branch August 3, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[select] select选中和下拉项中增加title属性是否显示的控制
3 participants