Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): expandType=popup时箭头方向错误问题 #806

Merged
merged 1 commit into from
May 20, 2022

Conversation

fengxianqi
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign-vue-next#644

💡 需求背景和解决方案

修复前:https://stackblitz.com/edit/angular-kqnx7y?file=src%2Fdemo.vue
image

修复后:
image

📝 更新日志

fix(menu): expandType=popup时箭头方向错误问题

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn
Copy link
Collaborator

uyarn commented Apr 26, 2022

这个好像是设计如此..

@fengxianqi
Copy link
Contributor Author

真的吗。。感觉不符合直觉,popup时是浮在右边的哦

@uyarn
Copy link
Collaborator

uyarn commented Apr 26, 2022

真的吗。。感觉不符合直觉,popup时是浮在右边的哦

让设计师看看 @Wen1kang

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

完成

@fengxianqi fengxianqi force-pushed the fix/submenu-popup branch 2 times, most recently from e262ec1 to 5ce805a Compare April 27, 2022 03:39
@codecov-commenter
Copy link

Codecov Report

Merging #806 (5ce805a) into develop (a0db0df) will increase coverage by 4.04%.
The diff coverage is 66.79%.

@@             Coverage Diff             @@
##           develop     #806      +/-   ##
===========================================
+ Coverage    57.56%   61.60%   +4.04%     
===========================================
  Files          346      354       +8     
  Lines        12828    13260     +432     
  Branches      2405     2499      +94     
===========================================
+ Hits          7384     8169     +785     
+ Misses        5200     4837     -363     
- Partials       244      254      +10     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
src/menu/menu.tsx 61.90% <ø> (ø)
src/select/option.tsx 16.66% <ø> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141efed...5ce805a. Read the comment docs.

@Wen1kang
Copy link

真的吗。。感觉不符合直觉,popup时是浮在右边的哦

的确这里是有问题,设计已修复了,五一节后我们修改menu和dropdown的样式 @fengxianqi

Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit 8b8a4f5 into Tencent:develop May 20, 2022
@xiaosansiji xiaosansiji mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants