Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-number): 透传 Input 组件全部特性,即 inputProps #930

Merged
merged 1 commit into from
May 29, 2022
Merged

feat(input-number): 透传 Input 组件全部特性,即 inputProps #930

merged 1 commit into from
May 29, 2022

Conversation

jchalex
Copy link
Contributor

@jchalex jchalex commented May 29, 2022

fix #917

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • [✅] 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#917

💡 需求背景和解决方案

  1. 希望在 t-input-number 中能自定义 t-input 的属性
  2. 将 props 透传给 t-input

📝 更新日志

  • feat(input-number): 透传 Input 组件全部特性,即 inputProps

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • [✅] 文档已补充或无须补充
  • [✅] 代码演示已提供或无须提供
  • [✅] TypeScript 定义已补充或无须补充
  • [✅] Changelog 已提供或无须提供

@jchalex jchalex changed the title feat(input-number): support props to t-input feat(input-number): 透传 Input 组件全部特性,即 inputProps May 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #930 (2ccb336) into develop (a0db0df) will increase coverage by 2.64%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #930      +/-   ##
===========================================
+ Coverage    57.56%   60.20%   +2.64%     
===========================================
  Files          346      376      +30     
  Lines        12828    14313    +1485     
  Branches      2405     2666     +261     
===========================================
+ Hits          7384     8617    +1233     
- Misses        5200     5433     +233     
- Partials       244      263      +19     
Impacted Files Coverage Δ
src/affix/affix.tsx 28.57% <0.00%> (-37.51%) ⬇️
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/message/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/tooltip/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/pagination/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/steps/step-item-props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e5839...2ccb336. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@chaishi chaishi merged commit 98c2780 into Tencent:develop May 29, 2022
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InputNumber] 透传 Input 组件全部特性,即 inputProps
3 participants