Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pretty cyclic reference handling #2524

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

jcrist
Copy link
Contributor

@jcrist jcrist commented Sep 14, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Previously cyclic references were only handled for container and dataclass types, but not namedtuple, attrs, or custom types. This fixes that, and expands the tests to cover these cases.

Previously cyclic references were only handled for container and
dataclass types, but not namedtuple, attrs, or custom types. This fixes
that, and expands the tests to cover these cases.
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Base: 98.64% // Head: 95.67% // Decreases project coverage by -2.97% ⚠️

Coverage data is based on head (ec54261) compared to base (7d126c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2524      +/-   ##
==========================================
- Coverage   98.64%   95.67%   -2.98%     
==========================================
  Files          73       73              
  Lines        7840     7843       +3     
==========================================
- Hits         7734     7504     -230     
- Misses        106      339     +233     
Flag Coverage Δ
unittests 95.67% <100.00%> (-2.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/__init__.py 93.54% <ø> (ø)
rich/console.py 96.43% <ø> (-1.58%) ⬇️
rich/pretty.py 98.98% <100.00%> (+<0.01%) ⬆️
rich/traceback.py 98.68% <100.00%> (ø)
rich/_windows_renderer.py 0.00% <0.00%> (-100.00%) ⬇️
rich/_win32_console.py 3.01% <0.00%> (-86.94%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants