Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wcwidth and cell widths. #3289

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update wcwidth and cell widths. #3289

merged 1 commit into from
Feb 27, 2024

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented Feb 26, 2024

The bug Textualize/textual#4073 showed that the version of wcwidth we are using incorrectly reports the soft hyphen (codepoint 173, 0xAD) as having length 1.

This was fixed in wcwidth 0.2.9, so updating wcwidth was enough.
I tested it and this fixes the linked Textual issue.

Bug Textualize/textual#4073 showed that the version of wcwidth we are using incorrectly reports the soft hyphen (codepoint 173, 0xAD) has having length 1.
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (aabfd16) to head (18ebb42).
Report is 217 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3289      +/-   ##
==========================================
- Coverage   98.30%   98.28%   -0.03%     
==========================================
  Files          74       74              
  Lines        8038     8049      +11     
==========================================
+ Hits         7902     7911       +9     
- Misses        136      138       +2     
Flag Coverage Δ
unittests 98.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodrigogiraoserrao rodrigogiraoserrao merged commit f4a7ed3 into master Feb 27, 2024
22 checks passed
@rodrigogiraoserrao rodrigogiraoserrao deleted the update-wcwidth branch February 27, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants