Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Build action fails as darglint checks the .venv folder made in previous step #311

Closed
Wiserfunding-CTO opened this issue Jul 5, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@Wiserfunding-CTO
Copy link

🐛 Bug Report

The GitHub Action build is calling Make which runs darglint against the root folder including .venv

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. Create a new project with this template using python 3.9 and push to remote origin

Or to reproduce locally

$ python3 -m venv .venv
$ make check-codestyle

Code sample

n/a

Environment

Python 3.9.4

Screenshots

image

image

📈 Expected behavior

Needs to exclude .venv or maybe darglint first then create .venv

📎 Additional context

@Wiserfunding-CTO Wiserfunding-CTO added the bug Something isn't working label Jul 5, 2021
TezRomacH added a commit that referenced this issue Jul 5, 2021
@TezRomacH
Copy link
Owner

Thanks for reporting. I have reproduced this bug, now I'm gonna fix it

@TezRomacH TezRomacH mentioned this issue Jul 5, 2021
11 tasks
TezRomacH added a commit that referenced this issue Jul 5, 2021
@TezRomacH
Copy link
Owner

The fix is in the latest release

cookiecutter gh:TezRomacH/python-package-template --checkout v1.0.3

Check it out! If there is still an error, please reopen this issue 👍🏻

@Wiserfunding-CTO
Copy link
Author

Nice fix. Impressively quick response.

@Wiserfunding-CTO
Copy link
Author

Spoke too soon. Same problem with bandit in the check-safety step

@TezRomacH
Copy link
Owner

Well, okay :) fix will be the almost the same, bandit has exclude parameter

@TezRomacH TezRomacH reopened this Jul 5, 2021
@TezRomacH TezRomacH mentioned this issue Jul 6, 2021
11 tasks
@TezRomacH
Copy link
Owner

I'm here again 😄
Try now, please 🙏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants