-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo Fix #2490
Typo Fix #2490
Conversation
Please do follow the pull request description given to you as it makes it easier for us to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice spotting the typo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the whole file will need updating to our guidelines, as the CI is complaining about it.
Would you like to work on this, @mmvergara, or create an issue for the same?
i'd like to work on it but sorry i don't really know how CI works, im kinda new to github. i might ruin something. |
no no he is asking you to fix the whole file and make it look better. |
What did i just do lol, sorry i really don't know how the flow in these PR's work 💀 |
you merged your pr with the main branch! i.e update your pull request so its up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we mean fix
the algorithm we mean is document and comment on the algorithm
make it neat and understandable.
try reading the contribution guidelines
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please use
climits
instead oflimits.h
. - Do not use
using namespace std
. Useusing <function>
(such asstd::cout
) or directly their namespace name. - Make sure to provide documentation and explanation of the algorithm, author, links, and self-test implementations.
If you need any help with this, let us know! 🙂
aight yeah. can someone actually finish this PR for me, sorry i'm not so used to github or C++ or this algorithm (yet). |
I'll work on this in the next few days. Thank you for contributing. 🙂 |
Originally initiated in #2490. Co-authored-by: Mark Matthew Vergara <mmvergara@users.noreply.github.com>
Originally initiated in #2490. Co-authored-by: Mark Matthew Vergara <mmvergara@users.noreply.github.com>
I got lazy sorry,