Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create priority_queue_using_list.py #2435

Merged
merged 5 commits into from
Sep 16, 2020
Merged

Create priority_queue_using_list.py #2435

merged 5 commits into from
Sep 16, 2020

Conversation

Ashley-J-George
Copy link
Contributor

@Ashley-J-George Ashley-J-George commented Sep 16, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1022f4c0-f806-11ea-8f9f-a900ee46d44b

@TravisBuddy
Copy link

Travis tests have failed

Hey @Ashley-J-George,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 05d8e9f0-f808-11ea-8f9f-a900ee46d44b

@Ashley-J-George
Copy link
Contributor Author

My new PR @cclauss

cclauss
cclauss approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisBuddy
Copy link

Hey @Ashley-J-George,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 204a18e0-f83a-11ea-8f9f-a900ee46d44b

@cclauss cclauss merged commit 1ac75f4 into TheAlgorithms:master Sep 16, 2020
@cclauss cclauss mentioned this pull request Sep 16, 2020
Closed
14 tasks
@Ashley-J-George Ashley-J-George deleted the patch-1 branch September 16, 2020 18:02
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Ashley-J-George @cclauss @stokhos
Create priority_queue_using_list.py (TheAlgorithms#2435)
69e99be 
* Create priority_queue_using_list.py

* Update priority_queue_using_list.py

* Update priority_queue_using_list.py

* Update priority_queue_using_list.py

* Maximum queue size is 100

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashley-J-George @TravisBuddy @cclauss