Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyphen_files = [file for file in filepaths if "-" in file] #2447

Merged
merged 8 commits into from
Sep 19, 2020
Merged

hyphen_files = [file for file in filepaths if "-" in file] #2447

merged 8 commits into from
Sep 19, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Sep 19, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Hey @cclauss,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 81bae2e0-fa14-11ea-8549-e58e00c6eb1f

realDuYuanChao
realDuYuanChao approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice scripts. LGTM.

@cclauss cclauss merged commit 363858e into master Sep 19, 2020
@cclauss cclauss deleted the hyphen_files branch September 19, 2020 05:13
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
hyphen_files = [file for file in filepaths if "-" in file] (TheAlgori…
c822259 
…thms#2447)

* hyphen_files = [file for file in filepaths if "-" in file]

* updating DIRECTORY.md

* Rename recursive-quick-sort.py to recursive_quick_sort.py

* updating DIRECTORY.md

* Rename aho-corasick.py to aho_corasick.py

* updating DIRECTORY.md

* Rename polynom-for-points.py to polynom_for_points.py

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realDuYuanChao realDuYuanChao realDuYuanChao approved these changes

@itsvinayak itsvinayak itsvinayak approved these changes

@aashigupta19 aashigupta19 Awaiting requested review from aashigupta19

@AnupKumarPanwar AnupKumarPanwar Awaiting requested review from AnupKumarPanwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @TravisBuddy @realDuYuanChao @itsvinayak