Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create problem_54 in project Euler #2451

Merged
merged 7 commits into from
Sep 20, 2020
Merged

Create problem_54 in project Euler #2451

merged 7 commits into from
Sep 20, 2020

Commits on Sep 19, 2020

  1. Add solution and test files for project euler 54

    @dhruvmanila
    dhruvmanila committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    cc6129c View commit details
    Browse the repository at this point in the history

  2. Update sol1.py

    @dhruvmanila
    dhruvmanila authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    97fe042 View commit details
    Browse the repository at this point in the history

  3. updating DIRECTORY.md

    github-actions authored and github-actions committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    e1d6980 View commit details
    Browse the repository at this point in the history

  4. Fix: use proper path to open files

    @dhruvmanila
    dhruvmanila authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    a2d2889 View commit details
    Browse the repository at this point in the history

  5. Commit suggestions: 

    - Use list comprehension instead of map
- Sort imports using isort
    @dhruvmanila
    dhruvmanila committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    fa9c267 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Changes made as suggested (simplified a lot): 

    - List and set comprehension instead of itemgetter
- Using enumerate as it's easy to read
- Divided into list of card values and set of card suit as set will
  remove all the duplicate values. So, no need for double indexing.
- Add test for testing multiple calls to five_high_straight function
    @dhruvmanila
    dhruvmanila committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    d9a84f2 View commit details
    Browse the repository at this point in the history

  2. Add suggestions and simplified: 

    - Split generate_random_hands function into two:
  - First will generate a random hand
  - Second, which will be called, will return a generator object
    @dhruvmanila
    dhruvmanila committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    781fa33 View commit details
    Browse the repository at this point in the history