Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization problem_10 in project_euler #2453

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Optimization problem_10 in project_euler #2453

merged 7 commits into from
Sep 22, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@realDuYuanChao
Copy link
Member Author

@cclauss Please review. Thanks :)

@cclauss
Copy link
Member

cclauss commented Sep 22, 2020

For optimizations it would be good to see a timeit benchmark that proves the performance gain.

@cclauss
Copy link
Member

cclauss commented Sep 22, 2020 •
edited
Loading

The most important tests to optimize are:
https://travis-ci.com/github/TheAlgorithms/Python/builds/185436069#L1437

@realDuYuanChao
Copy link
Member Author

@cclauss benchmark function output is below:

14.957698989999999
0.06171911999999935

It proved second version is more faster.

realDuYuanChao and others added 2 commits September 22, 2020 16:09
@realDuYuanChao @cclauss
Update project_euler/problem_09/sol1.py
466da9e 
Co-authored-by: Christian Clauss <cclauss@me.com>
updating DIRECTORY.md
0d0cdf0
@realDuYuanChao
Copy link
Member Author

@cclauss Done. Please review again.

@cclauss cclauss merged commit a1ea76b into TheAlgorithms:master Sep 22, 2020
@realDuYuanChao realDuYuanChao deleted the optimization branch September 22, 2020 14:19
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @cclauss @stokhos
Optimization problem_10 in project_euler (TheAlgorithms#2453)
1bafd9a 
* optimization for problem09 in project_euler

* added benchmark code

* fixup! Format Python code with psf/black push

* Update project_euler/problem_09/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* updating DIRECTORY.md

* Update project_euler/problem_09/sol1.py

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@AUNTB05 AUNTB05 AUNTB05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realDuYuanChao @cclauss @AUNTB05