Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed remove duplicate #2470

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fixed remove duplicate #2470

merged 2 commits into from
Sep 24, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@realDuYuanChao realDuYuanChao merged commit 3a275ca into TheAlgorithms:master Sep 24, 2020
cclauss
cclauss reviewed Sep 24, 2020
View reviewed changes
strings/remove_duplicate.py


if __name__ == "__main__":
print(remove_duplicates("INPUT_SENTENCE"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this line? Without it, the user runs the program and nothing happens.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think algorithm should not print anything. Because it have tested it using doctest.

Copy link
Member

@cclauss cclauss Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithmic function does not print() in alignment with CONTRIBUTING.md. The algorithmic function instead returns a string. However, it is more instructive (and intuitive) for the reader if main() does print the result of the algorithm. We are writing for humans to learn, not merely or computers to test.

@TheAlgorithms TheAlgorithms deleted a comment from realDuYuanChao Sep 24, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @stokhos
Fixed remove duplicate (TheAlgorithms#2470)
a6ee520 
* fixed remove duplicate

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realDuYuanChao @cclauss @l3str4nge