-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING - NetworkInfo new field: rpc_url #66
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 88.76% 89.06% +0.30%
==========================================
Files 6 6
Lines 623 631 +8
==========================================
+ Hits 553 562 +9
+ Misses 70 69 -1
☔ View full report in Codecov by Sentry. |
Let's not merge this yet, we might actually need the |
@cuteolaf It is possible to get the name and the parachainId of a network from an RPC: https://substrate.stackexchange.com/a/9093/2163 |
We need to know the RPC URL of the blockchains we intend to communicate with.
Removed
name
andss58_prefix
fromNetworkInfo
since it is possible to query them from the RPC.Added a new field,
account_type
, this is needed when sending XCM messages.