Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING - NetworkInfo new field: rpc_url #66

Merged
merged 5 commits into from
Jul 3, 2023
Merged

BREAKING - NetworkInfo new field: rpc_url #66

merged 5 commits into from
Jul 3, 2023

Conversation

Szegoo
Copy link
Member

@Szegoo Szegoo commented Jun 29, 2023

We need to know the RPC URL of the blockchains we intend to communicate with.

Removed name and ss58_prefix from NetworkInfo since it is possible to query them from the RPC.

Added a new field, account_type, this is needed when sending XCM messages.

contracts/identity/lib.rs Outdated Show resolved Hide resolved
@Szegoo Szegoo requested a review from cuteolaf June 30, 2023 08:59
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.30 🎉

Comparison is base (350c55c) 88.76% compared to head (a6c83f8) 89.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   88.76%   89.06%   +0.30%     
==========================================
  Files           6        6              
  Lines         623      631       +8     
==========================================
+ Hits          553      562       +9     
+ Misses         70       69       -1     
Impacted Files Coverage Δ
contracts/identity/lib.rs 97.12% <100.00%> (+0.74%) ⬆️
contracts/identity/tests.rs 98.62% <100.00%> (+0.02%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Szegoo
Copy link
Member Author

Szegoo commented Jul 1, 2023

Let's not merge this yet, we might actually need the name field.

@Szegoo
Copy link
Member Author

Szegoo commented Jul 2, 2023

@cuteolaf It is possible to get the name and the parachainId of a network from an RPC: https://substrate.stackexchange.com/a/9093/2163
If all the changes look good to you we can merge this.

@Szegoo Szegoo changed the title NetworkInfo new field: rpc_url BREAKING - NetworkInfo new field: rpc_url Jul 2, 2023
@Szegoo Szegoo merged commit 27b8fb8 into main Jul 3, 2023
5 checks passed
@cuteolaf cuteolaf deleted the network-rpc-url branch July 3, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants